This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(vite): close vite watcher before building#5875
Merged
Conversation
✅ Deploy Preview for nuxt3-docs canceled.
|
pi0
approved these changes
Jul 13, 2022
pi0
reviewed
Jul 13, 2022
| ctx.config.plugins.push({ | ||
| name: 'nuxt:close-vite-watcher', | ||
| configureServer (server) { | ||
| return server?.watcher?.close() |
Member
There was a problem hiding this comment.
Seems like a good workaround but I expect to track this issue. watcher starting for production build is a little bit strange
Member
Author
There was a problem hiding this comment.
agreed, it seems strange.
what do you think @antfu? should we raise upstream at vite?
Member
There was a problem hiding this comment.
should we raise upstream at vite?
Sure if we could provide a reproduction out-side of Nuxt.
Ideally the configureServer shouldn't even be called in build, or we might accidentally have a vite dev server on build?
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#14246
❓ Type of change
📚 Description
We continue watching files during the vite build process, and if (due to a race condition)
tsconfig.jsonis written after vite build starts it can trigger a vite error from the esbuild plugin.📝 Checklist